Add casts to two of the ll wrappers to prevent UB (and ASAN shouting about UB), in particular
multiplying signed integers that won't fit in a u64.
shifting signed integers by enough that they don't fit in a u64 (this does also remove the UB for shifting negative integers, I'm not sure what IDO would do there or if it's predictable).
In theory this may not always emulate the correct behaviour, but it builds both OoT and MM OK so in the rare cases that it matters it's probably fine.
Also formatted the makefile so it doesn't use tabs for things that are not recipes, this was certainly confusing my VSCode so it probably can cause other problems as well.
EllipticEllipsis
commented
2 years ago
Add casts to two of the
llwrappers to prevent UB (and ASAN shouting about UB), in particularIn theory this may not always emulate the correct behaviour, but it builds both OoT and MM OK so in the rare cases that it matters it's probably fine.
Also formatted the makefile so it doesn't use tabs for things that are not recipes, this was certainly confusing my VSCode so it probably can cause other problems as well.