search

decompals / wibo

Quick-and-dirty wrapper that tries to run 32-bit Windows command-line executables on Linux
MIT License
57 stars 19 forks source link

Move empty pattern check into while loop #81

Closed Pheenoh closed 2 months ago

Pheenoh commented 2 months ago

fixes #78

encounter commented 2 months ago

Thank you!

simonlindholm commented 2 months ago

This feels weird to me -- isn't it the same as "if (handle->pattern.empty()) { return false; }"?

Pheenoh commented 2 months ago

This feels weird to me -- isn't it the same as "if (handle->pattern.empty()) { return false; }"?

I don't completely understand the context here, but the handle's directory iterator not being iterated through was causing the file not found error in the linked issue due to an early return when there was an empty pattern, so that's why i moved it to the while loop.

Maybe there is a better fix, but I wanted to get something in here as it was breaking multiple projects using wibo with mwcceppc.exe

EDIT: Okay yeah this makes more sense lol