Incorrect hours displayed when client is in another timezone from the server

decompil3d / lovelace-hourly-weather

Hourly weather card for Home Assistant. Visualize upcoming weather conditions as a colored horizontal bar.

MIT License

304 stars 33 forks source link

Incorrect hours displayed when client is in another timezone from the server #464

Open bpinney opened 1 year ago

bpinney commented 1 year ago

Checklist:

[x] I updated to the latest version available
[x] I cleared the cache of my browser

Release with the issue: v4.13.0

Last working release (if known):

Browser and Operating System: Home Assistant Companion App 2023.7.5-full, Android 13 Firefox 115.0.3 (64-bit), MacOS 13.4.1

Description of problem:

It seems the server time zone offset is is not being applied to the hours displayed. As seen in this attached screenshot with server time zone set to -5:00 (13:53) and the client time zone set to +10:00 (7:53), the hourly weather card is displaying the weather for 8:00 rather than 14:00.

Screenshot_20230731-075344

Javascript errors shown in the web inspector (if applicable):

Additional information: Edit: This unexpected behavior occurs when using the "Use server time zone" option in the User settings page while the client is in a different time zone from the server.

decompil3d commented 1 year ago

Hi @bpinney. The hourly weather card uses a standard set of functions to format dates and times. It uses your user locale and timezone settings from HA. If you go to your User settings page (click your user name in the HA sidebar), you can configure those options and then the Hourly Weather card should pick those up.

bpinney commented 1 year ago

Thank you for your quick response @decompil3d. Yes, I had selected "Use server time zone (America/New York)" in the user settings page, which is why I was surprised to find the hours displayed matched the client time zone. Edit: I have updated the original issue to include this additional information.

decompil3d commented 1 year ago

Thanks for the additional information. I'll try to reproduce this when I have a moment.

GeneralLouis commented 1 year ago

I just recently re-created my home assistant for a "fresh" install and this bug is occurring for me as well. Interestingly, as I had both servers up, only the old one had the correct time on the weather card, regardless of which RPI 4b it was on, meaning it was not hardware dependent. (I recreated the current server as much as I could on 1GB, then swapped hard drives so the new fresh install was on the 4GB RPI 4b with the sky Connect and etc. attached). I have tried changing my time zones on both the server and the locale of the user, I even tried adjusting the timezone to see if the card would update, which it did not change. This bug occurs on Mac Chrome, Windows Chrome, Fully Kiosk on Fire Tablet, and Chrome on Android.

formatBCE commented 5 months ago

@decompil3d any movement on this? I tried to put other card with current time to same dashboard, and it shows correct local time - however, hourly weather card shows labels according to UTC+0, not mine UTC-7. (Tried using server/local time zone, also pretty sure the device i'm showing it on is in same -7 TZ...

formatBCE commented 5 months ago

P.S. i checked my forecast provider data, and the datetime field there is returned in UTC (e.g. "2024-06-12T16:00:00+00:00"), not respecting time zone. Could it be that you're taking time for label directly from there, without conversion?

But i'm stumped with the fact that i have it displayed correctly on my PC Chrome, however incorrect on Android clock device... That one has pretty outdated web view, by the way.