search

decompil3d / lovelace-hourly-weather

Hourly weather card for Home Assistant. Visualize upcoming weather conditions as a colored horizontal bar.
MIT License
298 stars 31 forks source link

Add 'partly cloudy night' #662

Open JanDetrez opened 6 months ago

JanDetrez commented 6 months ago

Is it possible to have a 'partly cloudy night' condition so we see an icon of a moon with clouds during the night, instead of the sun?

Of course, this requires the weather integration to provide this condition as well. I asked if the particular one I am using, can do this. https://github.com/jdejaegh/irm-kmi-ha/issues/16

To have a generalised solution, you could also consider to have the Lovelace integration check sunrise/sundown and edit the icon accordingly even if the weather integration does not discriminate between night and day. Not sure how/if it is technically possible to do this sort of override.

As you see below, it is a bit odd that during the night we see this 'partly cloudy' condition with a sun.

Screenshot_20240331-064528

JanDetrez commented 6 months ago

FYI in the post linked above @jdejeagh mentioned ways of solving this in the lovelace card :-) thanks for considering implementing this.

decompil3d commented 3 months ago

Reopening this since the original fix was buggy.

formatBCE commented 3 months ago

@decompil3d could that buggy fix (with sunrise/sunset usage) be the reason of https://github.com/decompil3d/lovelace-hourly-weather/issues/696 ? I was checking the changes between 5.4.0 and 6.0.0, and that function is the only suspicious thing (well, apart from bunch of lib updates, that could cause it of course), and since the time is also shown incorrectly for me, i thought maybe it's something with UTC/non-UTC stuff, or location settings?

P.S. actually, i see that you removed that code in 6.0.1 when disabled new changes. Let me install 6.0.1 and see if it works.

P.P.S. nope, it's some updated libs that causing it, unfortunately...