search

decompme / decomp.me

Collaborative decompilation and reverse engineering website
https://decomp.me
MIT License
348 stars 108 forks source link

Fix: misaligned GitHub link on profile page issue 686 #1225

Closed shubhankar-shandilya-india closed 2 months ago

shubhankar-shandilya-india commented 2 months ago

Hi @mkst @marijnvdwerf Fixed #686 I have added classes "justify-center md:justify-start" to the div holding github icon and the user name in span tag This fixed the issue

mkst commented 2 months ago

Thanks for the PR i can see the issue is fixed - just for my understanding, could you explain what the md:justify-start class does? And why it's also needed (i.e. why doesn't tailwind's justify-center class do enough)?

shubhankar-shandilya-india commented 2 months ago

Yes Sure @mkst

The 'justify-center' class is utilized to horizontally center the content within its container along the main axis. The 'md:justify-start' class is specifically targeting medium-sized screens (md stands for medium) and larger to horizontally align the content to the start of the container's main axis.

In short we can say that, The justify-center class ensures default alignment of contents at center, while md:justify-start is applied for medium and larger screens to ensure alignment at the start. This approach maintains consistency across various screen sizes.

mkst commented 2 months ago

Aha, thanks for the explanation - I see that this file doesn't use any external css,hence having to be done via classes. Makes sense!