search

decompme / decomp.me

Collaborative decompilation and reverse engineering website
https://decomp.me
MIT License
376 stars 116 forks source link

feat(frontend): allow presets to be explored in dedicated page #1232

Closed axel7083 closed 3 months ago

axel7083 commented 4 months ago

Description

This PR make the presets easier to explore and integrate them as part of the UI with the related resources.

Screenshots

/preset

The new preset page allows to list all the presets by platform. I am reusing the component from the NewScratchForm.

image

Related issues

Related to https://github.com/decompme/decomp.me/issues/648

conorgolden1 commented 4 months ago

I am looking to display comments on the user profile page. So we might be running into design conflicts here with the changes to the user page. Also I am wondering what would happen in your implementation you requested to show more of the users scratches? Would that just extend the preset section further down the page?

I am just thinking maybe to future proof this a little we add tabs to the user profile page that can then be added onto with future features such as this.

ethteck commented 4 months ago

I'm not sure comments belong on a user page since you lose the context of the scratch to just have a bunch of comments. or maybe there's a way to do that you have in your head I'm not considering. but yeah I am down with the tabs idea, I think

ethteck commented 4 months ago

Another thought:

I think showing a few presets at the top of a platform page is good, but if we list all of them, the scratches will be quite far down the page. maybe we could do the tabs thing there too, or a two-column view? not sure..

axel7083 commented 4 months ago

Another thought:

I think showing a few presets at the top of a platform page is good, but if we list all of them, the scratches will be quite far down the page. maybe we could do the tabs thing there too, or a two-column view? not sure..

I simplified this PR, by only adding the /preset page for now.

I also think it would be great to have some presets in the platform page, but adding a tab section could be another PR!

ethteck commented 4 months ago

this looks great! a few thoughts:

  1. it'd be cool if we had a sortable PresetList (number of scratches, recent activity, alphabetical, creation date, all ascending or descending). we can address this in a future PR, since it'd require backend changes
  2. It'd also be cool if we could show the number of scratches in the Preset item somewhere. Exposing this in a nice way might warrant changing the backend, so we can tackle this later too.
  3. We can probably do away with the platform logo on this particular page, since we're filtering by platform anyway.
ethteck commented 4 months ago
  1. the platform logo in the filter selection at the top of the page should not be a link

(3 and 4 should probably be addressed in this PR before merge, and I can write an issue for 1 and 2)

axel7083 commented 4 months ago
  1. the platform logo in the filter selection at the top of the page should not be a link

(3 and 4 should probably be addressed in this PR before merge, and I can write an issue for 1 and 2)

@ethteck 3 ans 4 have been implemented ✅

bates64 commented 4 months ago

I like this PR! Thanks for the contribution - just some small code style things to fix up.

axel7083 commented 3 months ago

Result can be visible through the vercel deployment https://frontend-git-fork-axel7083-feature-frontend-presets-decompme.vercel.app/preset

bates64 commented 3 months ago

Thanks for the fixes :) Looks like there are some conflicts. Soon as they're resolved we can merge this👍

axel7083 commented 3 months ago

Thanks for the fixes :) Looks like there are some conflicts. Soon as they're resolved we can merge this👍

Yeahhh, should be good now :)

axel7083 commented 3 months ago

@bates64 ready to be merge !