decompme / decomp.me

Collaborative decompilation and reverse engineering website
https://decomp.me
MIT License
383 stars 119 forks source link

MSVC8.0 cannot find windows.h #1314

Closed abnormalhare closed 3 months ago

abnormalhare commented 3 months ago

Describe the bug Attempting to include Windows.h fails when using the new msvc8.0 compiler.

To Reproduce Steps to reproduce the behavior:

  1. Create a new scratch using msvc8.0
  2. Go to Context
  3. Type #include <Windows.h>
  4. See error

Expected behavior Windows.h is include, like in msvc6.0

Scratches https://decomp.me/scratch/zQnyW

mkst commented 3 months ago

one for @widberg - there is no WINDOWS.H in the Include directory.

https://github.com/decompme/compilers/pull/22

widberg commented 3 months ago

It looks like Windows.h is in the PlatformSDK directory with the other windows headers https://github.com/widberg/msvc8.0/blob/main/PlatformSDK/Include/Windows.h. I did not set this up to get copied over in the compilers repo, oops. How should I update the compiler definition to have multiple include directories copied? I'd like to keep the directory structure on the main branch the same as the installed VC directory, but I could squash the PlatformSDK sub-directories into the root on a separate branch and use that in the compilers repo to avoid having multiple include directories on the site.

mkst commented 3 months ago

I'll have a crack at it tomorrow, allow for multiple include directories as part of the Jinja templating 😎

mkst commented 3 months ago

Should be fixed via https://github.com/decompme/compilers/commit/2ff07e6fee34b0543ede9560cf0ede27a4f4ae03, will need a restart of the site to pull down the new compiler image.

mkst commented 3 months ago

This scratch is now compiling successfully with msvc8.0 - thanks for raising the issue!

image