search

decompme / decomp.me

Collaborative decompilation and reverse engineering website
https://decomp.me
MIT License
376 stars 116 forks source link

[BUG] Wrong instruction has a lower (better) score than the exact matching instruction #1352

Closed joshlory closed 1 day ago

joshlory commented 3 days ago

Describe the bug I could be missing something obvious... I'm seeing a better match score for 40: move v0,zero than the actual matching instruction 40: li v0,1

To Reproduce Steps to reproduce the behavior:

  1. Go to https://decomp.me/scratch/y3vrf
  2. Open the 3-way compare view
  3. Change line 37 ("change me") from return 1 to return 0
  4. See the issue

Expected behavior Score decreases

Screenshots

image image

Scratches See repro steps above

Desktop (please complete the following information if applicable):

joshlory commented 3 days ago

Could be that the re-ordered version is better that the version with more lines matching. So maybe not a bug.

mkst commented 3 days ago

It would be an issue for asm-differ, but as you say, the lower score has more correct instructions