search

deconf / Analytics-Insights

GNU General Public License v2.0
5 stars 7 forks source link

Improve I18N Issues (Based on 6.3) #15

Closed alexclassroom closed 8 months ago

alexclassroom commented 8 months ago
  1. Correct the current ISO 3166 country codes' country names; there are some duplicated country names. For example, there are two Congo in the country names menu.
  2. Make the country names menu localizable.
alexclassroom commented 8 months ago

And...

Taiwan is an independent country, NOT a part of China; thanks for keeping "Taiwan" in the country names menu.

deconf commented 8 months ago

Hi,

Both keys and values from the array are used, keys on Google Charts and values on Google Analytics API. Localization should be only made before list output, since translating the keys or values will interfere with those two.

alexclassroom commented 8 months ago

Thanks for letting me know, I closed this PR.