deconst / deploy

Ansible playbook to deploy Deconst onto a cluster
Apache License 2.0
5 stars 8 forks source link

Switch from /dev/random to /dev/urandom #121

Closed kenperkins closed 6 years ago

kenperkins commented 7 years ago

I've noticed cases were using /dev/random has resulted in blocking when running deploy on a virtual machine. Based on http://unix.stackexchange.com/a/243218 we should be using /dev/urandom anyway.

https://github.com/deconst/deploy/blob/master/certificates.yml#L43

robb-romans commented 6 years ago

The only instance of this is in the credentials example file command to create an API key, which I don't think is much of a problem. The certificates file has already been changed. I checked the other deconst-* repos and don't see it.

 Deconst  deploy  find . -type f | xargs grep \/dev\/random
./credentials.example.yml:#  hexdump -v -e '1/1 "%.2x"' -n 128 /dev/random
  Deconst  deploy  find . -type f | xargs grep \/dev\/urandom
./certificates.yml:      head -c 128 /dev/urandom | base64 > certificates/tmppassword &&