deconz-community / node-red-contrib-deconz

Node-Red Nodes for deCONZ connectivity.
GNU General Public License v3.0
84 stars 16 forks source link

"OUT" Node not useable anymore with Deconz 2.3.6 on Safari #217

Closed EdStark666 closed 1 year ago

EdStark666 commented 1 year ago

Current Behavior

"OUT" Node has a bug which leads to the situation, that no commands can be set. Because of that, devices cant be controlled anymore with Deconz in Nodered.

Expected Behavior

Add commands in the OUT node like before.

Steps To Reproduce

Create OUT Node in Nodered and try to add homekit or state or config or custom command.

Example flow

paste your flow here

Environment

EdStark666 commented 1 year ago

Seems to be a safari problem. Works on chrome browser as before.

Zehir commented 1 year ago

What version of Safari are you using ? Did you have errors in the console ?

EdStark666 commented 1 year ago

Safari 16.0 on macOS 12.6 Monterey (newest SW). Screenshot of issue: https://im.ge/i/2sjsLz Yes, there are errors, screenshot https://im.ge/i/2sjqTS

Zehir commented 1 year ago

This can't help me, I will try to install safari on windows later

Zehir commented 1 year ago

I tried on a new node using a safari from a virtual machine and I can't reproduce the issue. Could you come over discord to talk about that issue ? I ping you here.

dionmes commented 1 year ago

I got the same issue. The specifics option section and commands section do not expand or are populated under safari on MacOS. This is the first time I try this out, thought I did something wrong but then saw this thread.

Safari Version 16.1 (18614.2.9.1.12)

fuzzy01 commented 1 year ago

I have the same issue on MacOS. Very annoying.

Safari Version 16.1 (18614.2.9.1.12) MacOS Ventura 13.0.1

raddi commented 1 year ago

Same issue on macOS Ventura 13.0.1 and Safari 16.1 - The Commands tab seems to be empty, but in Chrome it does work, so there may are some display issues in safari?

Bildschirm­foto 2022-12-11 um 18 43 23
Zehir commented 1 year ago

I have no idea why this don't work on safari and I can't reproduce on my side. Somebody can come on discord to debug this in real time ?

Zehir commented 1 year ago

Does this happen on ipad too ?

dionmes commented 1 year ago

I can confirm this happens on iPad too and also in Chrome on the iPad (which makes sense).

Zehir commented 1 year ago

For some reason doing this fix the issue :

  async generateTypedInput(container, options, stupidFix = "safari") {
    console.log("Stupid fix for " + stupidFix);

By adding an new param and doing something with it like print in the console it's fix. The issue is that the options value became undefined but it defined when the method is called. I don't understand what is happening here.

I looking for a better fix

Zehir commented 1 year ago

Released in 2.3.7

dionmes commented 1 year ago

Sounds good, but in NR I can already upgrade to 2.3.8.

Zehir commented 1 year ago

Sounds good, but in NR I can already upgrade to 2.3.8.

Yes à push an other update in between

Automayted commented 1 year ago

I'm seeing a very similar issue in macOS 12.6.1 with Safari 16.2 running v2.3.8.

Safari shows a mix of light and cover parameters, notably missing transition time: Screen Shot 2022-12-27 at 11 05 08 PM

Chrome shows everything correctly: Screen Shot 2022-12-27 at 11 05 15 PM

I've cleared all Safari cache, rebooted, all with no change.

Am I overlooking something obvious, or is there still an issue with Safari in v2.3.8?

Zehir commented 1 year ago

Damned safari

Automayted commented 1 year ago

Damned safari

Ha. Let me know if I can offer any assistance with logs or whatnot. Thanks for all your efforts on this project!

Zehir commented 1 year ago

Damned safari

Ha. Let me know if I can offer any assistance with logs or whatnot. Thanks for all your efforts on this project!

Yes could you check on the browser console if there is any errors ?

Automayted commented 1 year ago

Damned safari

Ha. Let me know if I can offer any assistance with logs or whatnot. Thanks for all your efforts on this project!

Yes could you check on the browser console if there is any errors ?

I get this one each time I open a deCONZ OUT node:

[Error] Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'container.append') (anonymous function) (deconz-editor.js:1:41856) asyncFunctionResume (anonymous function) promiseReactionJobWithoutPromise promiseReactionJob

Zehir commented 1 year ago

Ok I see it's the same safari bug where object became undefined by magic, I will work on a fix this weekend

Zehir commented 1 year ago

Was related to https://github.com/mishoo/UglifyJS/issues/5155