decosoftware / deco-ide

The React Native IDE
https://www.decosoftware.com/
GNU Affero General Public License v3.0
5.84k stars 311 forks source link

File contents in Deco should be changed with external changes #61

Open ele828 opened 8 years ago

ele828 commented 8 years ago

If we modify a file externally, the content of that file in Deco will not be changed at the same time, while other IDEs or text editors will. Should we fix it?

dabbott commented 8 years ago

Yes, absolutely!

One complication is that Deco lets you have inspectable properties with associated metadata, and if the code changes outside of Deco, those properties will get a little screwed up (they are stored based on character/line position in the file). That's okay - but we should also invalidate/delete any inspectable properties if they are no longer accurate (e.g. if a property that used to be "42" of type string was shifted a few characters and now contains junk and is no longer a string, like = "4, we should remove it from the inspector)

MutableLoss commented 8 years ago

Just to add to this, I'm not sure if it's the current want Deco handles files, but I have had Deco freeze when selecting the package.json after it has been changed externally with npm/rnpm. I have not found a good way to reproduce this indefinitely, but it has been an issue when trying to access this file. I will make another issue when I can.

Deco 1.1.2/0.7.1