search

decred / Paymetheus

Decred wallet for Windows.
ISC License
12 stars 11 forks source link

Be backwards compatible with v1 API pools. #248

Closed jrick closed 7 years ago

jrick commented 7 years ago

When there are no pools advertising v2, do not show the vote preferences.

Fixes #247

jrick commented 7 years ago

Note that this change is still incomplete. Something needs to be decided upon for how to handle situations where votebits have already been set with v1 pools configured (e.g. the user did this on 1.0.0, or had multiple pools configured and some were v1 and others v2). Currently, when the pool upgrades to v2, these preferences won't be sent to the pool again unless the user changes their preferences.

marcopeereboom commented 7 years ago

I am not sure there is a solution for this minus documenting it. Only thing I can come up with is a single shot dialog that warns the user about this once he/she upgrades but I am not sure we can catch all of these either.

jrick commented 7 years ago

It will have to be documented in the release notes as there is no way for us to know when pools have upgraded to newer APIs (although this could be solved by saving versions in the stakepoolcfg.json file, hmmmm)