search

decred / atomicswap

On-chain atomic swaps for Decred and other cryptocurrencies.
https://blog.decred.org/2017/09/20/On-Chain-Atomic-Swaps/
ISC License
507 stars 232 forks source link

[cmd][xzcatomicswap] Change dumprivkey RPC sequence for Zcoin #102

Closed devwarrior-cool closed 5 years ago

devwarrior-cool commented 5 years ago

Zcoin added a one-time authorization key returned in error string from a first call to dumpprivkey. Along with a warning. The key is used in 1 (one) subsequent call to the same RPC function. The idea is that inexperienced people are warned if scammers propose they use `dumpprivkey'.

devwarrior-cool commented 5 years ago

please merge dpk3

devwarrior-cool commented 5 years ago

are you 100% sure?

devwarrior-cool commented 5 years ago

and then how to manage the rebase that would then be demanded?

xaur commented 5 years ago

Good question.

You can fetch the refs/pull/102/head ref but I never tried pushing to it. What I would try is to reinstate your fork and create a branch with the same name that was used to start the PR, and push to it. Second idea is ask maintainer to rebase.

If both fail then indeed restarting a PR is the only way to go when you delete the fork and lose access to source branch.