decred / atomicswap

On-chain atomic swaps for Decred and other cryptocurrencies.
https://blog.decred.org/2017/09/20/On-Chain-Atomic-Swaps/
ISC License
508 stars 231 forks source link

Fix signrawtransaction not found error #109

Closed vctt94 closed 5 years ago

vctt94 commented 5 years ago

fixes #105

needs: https://github.com/btcsuite/btcd/pull/1413 and https://github.com/btcsuite/btcd/pull/1415

jrick commented 5 years ago

Thanks for this

In case it takes too long for the btcd PRs to be merged, you can still call the RPC through the use of the raw APIs. We already do this for fundrawtransaction.

https://github.com/decred/atomicswap/blob/532f01ef64588676cc214b413a0da63f81590b8d/cmd/btcatomicswap/main.go#L406

vctt94 commented 5 years ago

Should I add the raw commands to the API into this PR?

imestin commented 5 years ago

What is the situation with this pull request? I would like to create a test transaction. Should I wait for this pull request, or should I try to fix it with some temporary solution?

vctt94 commented 5 years ago

Not sure if this PR is updated with the current btcd repo. But you can use https://github.com/decred/atomicswap/pull/111 which calls the request by raw request as @jrick suggested.

imestin commented 5 years ago

thank you! it worked.

jrick commented 5 years ago

Obsoleted by #111.