search

decred / atomicswap

On-chain atomic swaps for Decred and other cryptocurrencies.
https://blog.decred.org/2017/09/20/On-Chain-Atomic-Swaps/
ISC License
507 stars 232 forks source link

In README, links to Bitcoin testnet explorer were updated #112

Open imestin opened 5 years ago

imestin commented 5 years ago

The links for Decred (testnet) are still not working, because non of the block explorers I know about could find those transactions.

The Bitcoin links were not working, because blocktrail.com ceased operations.

jrick commented 5 years ago

The examples were done on testnet2 and decred is currently on testnet3, so they need to be entirely redone.

imestin commented 5 years ago

I tried to recreate the transactions.

After I run ./bitcoin-cli -testnet getnewaddress

./btcatomicswap --testnet --rpcuser=user --rpcpass=AtomicSwap1234 initiate 2N8S4gAgJSY8G9fMmRoR2hoNprgRFWRFcT2 0.001 will result: participant address is not P2PKH

imestin commented 5 years ago

I tried to create a SegWit compatible address in Bitcoin-qt, that also didn't work. tb1q3nw54nyj44eewnkswv2jtqhqrl7rpr2t7tqmm5

I'm still trying to figure this out, if I will have a solution I will post it here.

jrick commented 5 years ago

You need to generate p2pkh addresses (aka legacy). getnewaddress should let you specify the kind.

imestin commented 5 years ago

OK, it works.

bitcoin-cli -testnet getnewaddress random_comment legacy will work

imestin commented 5 years ago

signrawtransaction: -32: signrawtransaction was removed in v0.18. Clients should transition to using signrawtransactionwithkey and signrawtransactionwithwallet

imestin commented 5 years ago

I will create an issue with the above mentioned problem.

UPDATE: there is already a pull request for that. https://github.com/decred/atomicswap/pull/109