search

decred / atomicswap

On-chain atomic swaps for Decred and other cryptocurrencies.
https://blog.decred.org/2017/09/20/On-Chain-Atomic-Swaps/
ISC License
507 stars 232 forks source link

Monacoin support #53

Closed wakiyamap closed 6 years ago

wakiyamap commented 6 years ago

testnet4(monacoin is testnet ver4) case https://gist.github.com/wakiyamap/137703f07311e0af70231e875485c96f

mainnet case https://gist.github.com/wakiyamap/e51bf1a028fe12c72a02e48d01835db5

jrick commented 6 years ago

Nice job with the port. After a quick glance, it looks like some amounts are still being formatted as BTC though. To fix that, change the String method for AmountUnit (https://github.com/wakiyamap/monautil/blob/master/amount.go#L33).

I'm going to finish reviewing all of the other ports with open pull requests first before I take a closer look, but should be able to get to this soon. You will need to rebase this over those once they have been merged since there will be conflicts with the Gopkg.lock, and I'll let you know when you can do that.

wakiyamap commented 6 years ago

@jrick thanks!! I fix it and rebase.

jrick commented 6 years ago

This is reviewed and ready except for the Gopkg.toml/lock conflicts.

wakiyamap commented 6 years ago

I misunderstood about rebase. thanks