search

decred / bitcore

Decred fork of bitcore.
Other
5 stars 28 forks source link

Fix PrivateKey.toWIF #8

Closed fanatid closed 7 years ago

fanatid commented 7 years ago

to wif in dcrd -- https://github.com/decred/dcrutil/blob/883bcecb86cda037f14a22ef923a5ea79f751512/wif.go#L124

jcvernaleo commented 7 years ago

This looks good to me. @alexlyp you touched this last so do you agree?

alexlyp commented 7 years ago

Ya should be fine i think, don't believe we use any of that functionality in the copay/insight stack

fanatid commented 7 years ago

Thank you.

peterzen commented 7 years ago

The multisig wallet creation in Copay relies on toWIF; this change causes bitcore to generate an invalid secret.

bitcore-wallet-client

https://github.com/decred/bitcore-wallet-client/issues/11

alexlyp commented 7 years ago

In lieu of @peterzen's findings I will be reverting this PR