decred / copay

A multisignature Decred wallet.
MIT License
5 stars 18 forks source link

Some words in passphrase have capital letters #54

Closed hrishikeshio closed 7 years ago

hrishikeshio commented 7 years ago

e.g. screen shot 2017-03-31 at 2 27 13 pm

It creates unnecessary confusion. it is not clear if the passphrase is case sensitive.

jcvernaleo commented 7 years ago

We use the pgp wordlist https://en.wikipedia.org/wiki/PGP_word_list so we cannot (and should not) change the words we use. Some words are presented with capital letters, others are not so I see no reason at all why it would not be case sensitive. Sorry, but nothing we can do in this case.

hrishikeshio commented 7 years ago

Then we should at least put a warning saying the words are case sensitive? @jcvernaleo

jcvernaleo commented 7 years ago

I don't see what would make anyone think they aren't case sensitive.

hrishikeshio commented 7 years ago

Well. The passphrase shown in original copay bitcoin wallet are not case sensitive. I only came to know that they are case sensitive in this case after reading your comment. Capital words should be avoided imho, as they can create confusion such as between "I" and "l". (although I know such words are not part of this list)

It would not hurt to give a warning, as someone can easily miss this small detail and lose a lot of money.

jcvernaleo commented 7 years ago

As stated above, they CANNOT be avoided since we take this from the PGP wordlist. And you cannot use the wallet without confirming that you know the seed by reentering the passphrase (where the correct capitalization is show). And the pgpwordlist does not ever have a capital and non-capital word so even if you screw up and don't write down the words with correct capitalization it is a trivial task to figure out the correct word from the list. So I see no possibility of losing funds.

hrishikeshio commented 7 years ago

I see.