search

decred / dcrdex

The Decred Decentralized Exchange (DEX), powered by atomic-swaps.
Other
185 stars 92 forks source link

app: unhandleable spot price notes prior to login #1241

Closed chappjc closed 2 years ago

chappjc commented 3 years ago

When dexc is started up and automatically connects to any configure DEX servers, it starts sending spot price notes. But when the pages have not logged in yet:

image

Each note results in this:

image

https://github.com/decred/dcrdex/blob/f7bb867dda5193987280848224796b26220405c2/client/webserver/site/src/js/app.js#L521-L524

chappjc commented 2 years ago

Bump as I think we should fix for next patch.

On a somewhat related note, I'm not concerned about the logged [ERR] CORE: subPriceFeed: unable to fetch market overview: rpc error: error code 2: unknown route since that will go away when server updates, but this JS error will not.

chappjc commented 2 years ago

bump in case anyone is looking for work. This is still a console error with 0.4 release

It can also happen at some point in the registration sequence

image

NOTE: The error here is slightly different, and corresponds to a revision where line 522 is the for loop line. In the OP of this issue, it was this.user.exchanges that was undefined, but in this comment it's that there's no entry for note.host and xc becomes undefined.

chappjc commented 2 years ago

For another day

chappjc commented 2 years ago

Resolved by https://github.com/decred/dcrdex/pull/1624