decred / dcrdex

The Decred Decentralized Exchange (DEX), powered by atomic-swaps.
Other
186 stars 94 forks source link

ux: placed orders should try to survive Bison wallet restart #2986

Open norwnd opened 1 month ago

norwnd commented 1 month ago

Running Bison wallet on personal PC/laptop presents the following challenge:

I could cancel orders manually also before shutting down Bison wallet, but I don't even always remember Bison wallet is running (and that's too much to ask anyway).

This can probably be automated by:

JoeGruffins commented 1 week ago

Currently the server will cancel your booked orders after some time. If they have not matched I don't think there is a penalty.

Canceling all orders upon normal shutdown sounds reasonable to me. I don't know why we don't do that already tbh.

I don't know if restoring previous orders is a great idea. If the markets have swung wildly you could be shooting yourself in the foot.

norwnd commented 1 week ago

I don't know if restoring previous orders is a great idea. If the markets have swung wildly you could be shooting yourself in the foot.

I thought about it too, my reasoning for restoring orders would be:

if I didn't cancel limit order(s) explicitly I am OK with them executing because it's the same thing that happens on CEX - if I close my Binance browser tab(s) and get back to it later, my orders might have executed since I didn't cancel those explicitly on Binance (the only difference being Bison DEX won't execute orders for you while you are offline)