Update VSP/ticket buying pages.

decred / dcrdocs

Documentation for Decred.

https://docs.decred.org

ISC License

81 stars 129 forks source link

Update VSP/ticket buying pages. #1217

Closed jholdstock closed 1 year ago

jholdstock commented 1 year ago

Reviewed most of the VSP/ticket buying pages to ensure they are up to date. Most of the detail is in individual commit messages.

Removed most references to Redeem Scripts. What remains is on a dedicated page which is clearly labelled as outdated information (redeem-script.md)
Removed "legacy" staking instructions. Simplified the remaining staking instructions by removing duplicated and overly verbose information.

jholdstock commented 1 year ago

Tagging some potential reviewers - @matthawkins90 @xaur

jholdstock commented 1 year ago

Thanks for the review.

Implemented some of your suggestions, but as you mention, the rest are probably good for another PR or maybe even another page? Things like using multiple VSPs or registering historic tickets with VSPs are more advanced imo, not suitable for the beginners guide. The main goal of this PR was to just remove the completely outdated info.

xaur commented 1 year ago

Agreed, this is already a nice cleanup/update and good to go as is. Better move in smaller steps but get more stuff merged.

Appreciate the example log lines, now users will know exactly what to look for.

For future PRs I'd suggest keep it on the same page but move processunmanaged, multi-VSP and other tricks to "Advanced..." section at the end. The only thing I'd keep in the main section is the numtickets parameter, it looks like it should be pretty common.