Enables use of estimatefee for built-in wallets. The old CreateSimpleTx btc impl created a fully signed transaction. But we are only using it to get an estimated fee based on available wallet input sizes and scripts, and the maximum signed serialized size -> fees are calculated without the need to actually sign. So I've changed CreateSimpleTx(...) *AuthoredTx to EstimateTxFee(..) int64 to better capture its intent and skip the unneeded signing.
Tested by hand, but I'm also trying to work it into interface_test.go.
matheusd
commented
8 months ago
Enables use of
estimatefeefor built-in wallets. The oldCreateSimpleTxbtc impl created a fully signed transaction. But we are only using it to get an estimated fee based on available wallet input sizes and scripts, and the maximum signed serialized size -> fees are calculated without the need to actually sign. So I've changedCreateSimpleTx(...) *AuthoredTxtoEstimateTxFee(..) int64to better capture its intent and skip the unneeded signing.Tested by hand, but I'm also trying to work it into
interface_test.go.