search

decred / dcrlnd

Decred Lightning Network Daemon ⚡️
MIT License
36 stars 24 forks source link

data race: seen in CI output #54

Closed dajohi closed 4 years ago

dajohi commented 4 years ago 
=== RUN   TestLightningWallet/dcrwallet/dcrd:signed_with_tweaked_pubkeys
=== RUN   TestLightningWallet/dcrwallet/dcrd:test_cancel_non-existent_reservation
=== RUN   TestLightningWallet/dcrwallet/dcrd:last_unused_addr
==================
WARNING: DATA RACE
Write at 0x0000021c24d0 by goroutine 79:
  github.com/decred/dcrlnd/lnwallet_test.TestLightningWallet()
      /home/runner/work/dcrlnd/dcrlnd/lnwallet/dcrwallet/log.go:32 +0x471
  testing.tRunner()
      /opt/hostedtoolcache/go/1.13.4/x64/src/testing/testing.go:909 +0x199

Previous read at 0x0000021c24d0 by goroutine 115:
  github.com/decred/dcrlnd/lnwallet/dcrwallet.(*RPCSyncer).start.func1()
      /home/runner/work/dcrlnd/dcrlnd/lnwallet/dcrwallet/rpcsync.go:59 +0x1d2

Goroutine 79 (running) created at:
  testing.(*T).Run()
      /opt/hostedtoolcache/go/1.13.4/x64/src/testing/testing.go:960 +0x651
  testing.runTests.func1()
      /opt/hostedtoolcache/go/1.13.4/x64/src/testing/testing.go:1202 +0xa6
  testing.tRunner()
      /opt/hostedtoolcache/go/1.13.4/x64/src/testing/testing.go:909 +0x199
  testing.runTests()
      /opt/hostedtoolcache/go/1.13.4/x64/src/testing/testing.go:1200 +0x521
  testing.(*M).Run()
      /opt/hostedtoolcache/go/1.13.4/x64/src/testing/testing.go:1117 +0x2ff
  main.main()
      _testmain.go:168 +0x223

Previous read at 0x0000021c24d0 by goroutine 115:
  github.com/decred/dcrlnd/lnwallet/dcrwallet.(*RPCSyncer).start.func1()
      /home/runner/work/dcrlnd/dcrlnd/lnwallet/dcrwallet/rpcsync.go:59 +0x1d2
Goroutine 115 (finished) created at:
  github.com/decred/dcrlnd/lnwallet/dcrwallet.(*RPCSyncer).start()
      /home/runner/work/dcrlnd/dcrlnd/lnwallet/dcrwallet/rpcsync.go:52 +0x526
  github.com/decred/dcrlnd/lnwallet/dcrwallet.(*DcrWallet).Start()
      /home/runner/work/dcrlnd/dcrlnd/lnwallet/dcrwallet/wallet.go:151 +0x13f
  github.com/decred/dcrlnd/lnwallet.(*LightningWallet).Startup()
      /home/runner/work/dcrlnd/dcrlnd/lnwallet/wallet.go:314 +0x86
  github.com/decred/dcrlnd/lnwallet_test.createTestWallet()
      /home/runner/work/dcrlnd/dcrlnd/lnwallet/interface_test.go:367 +0x4ba
  github.com/decred/dcrlnd/lnwallet_test.runTests()
      /home/runner/work/dcrlnd/dcrlnd/lnwallet/interface_test.go:3046 +0x13b5
  github.com/decred/dcrlnd/lnwallet_test.TestLightningWallet()
      /home/runner/work/dcrlnd/dcrlnd/lnwallet/interface_test.go:2823 +0x1345
  testing.tRunner()
      /opt/hostedtoolcache/go/1.13.4/x64/src/testing/testing.go:909 +0x199
==================
matheusd commented 4 years ago

52 should fix this via https://github.com/decred/dcrlnd/pull/52/commits/244b20655a8452239fb394651cc45cd47d98b08f

matheusd commented 4 years ago

Hasn't been triggered for a while, so closing.