search

decred / dcrlnd

Decred Lightning Network Daemon ⚡️
MIT License
36 stars 24 forks source link

Network command line switches for `dcrlnd` and `dcrlncli` which closes #70 #71 #72

Closed termoose closed 4 years ago

termoose commented 4 years ago

This is pull request for #70 and #71 as they were somewhat connected.

fguisso commented 4 years ago

Change this will impact another points of the code, I don't give an test, but just with search in files with Ack I found two files that need atention, sample-dcrlnd.conf and lnd.go:144. Please verify and test.

I don't now if we need regtest in dcrlncli, @matheusd can answer better.

btw, thanks for the PR, welcome to Decred!

termoose commented 4 years ago

Thanks for the great feedback! I wasn't sure what was meant by some attention needed at lnd.go:144? Also the regtest support is still there, I'm not sure if that's even usable with lightning

fguisso commented 4 years ago

Sorry about lnd.go:144, just cache in my git. LGTM, just await the CI finish the jobs

termoose commented 4 years ago

I'm not able to tell why the integration test failed, but noticed while investigating that I need to also change some documentation to update them with the new arguments

fguisso commented 4 years ago

I'm working on Docker dir, just change the anothers docs and I'm update my Dockers PR #66

matheusd commented 4 years ago

Excellent! Please just squash all commits into a single one and use an appropriate title for it (such as multi: Remove network CLI argument or something to that effect)