search

decred / dcrpayments

mono repo that houses various libraries/utilities for accepting Decred payments
8 stars 6 forks source link

PHP_Blake: fix or replace module #6

Closed jolan closed 6 years ago

jolan commented 6 years ago

As mentioned in the README, the tests cause crashes and there are various issues but this is worked around/doesn't effect php-addressgen.

When porting PHP_Blake from PHP5 to PHP7, I just looked at the API changes between 5 -> 7 and did a straight port. There is a lot of room for simplication. For instance, looking at https://github.com/strawbrary/php-blake2, the module glue could be a lot cleaner with PHP7 than it is currently.

Might be nice to rename the function/module to blake256/blake256.so as well or replace with pure PHP code.

jolan commented 6 years ago

This has almost been completed by @R3VoLuT1OneR and the README has been updated.