search

decred / dcrwallet

A secure Decred wallet daemon written in Go (golang).
https://decred.org
ISC License
218 stars 154 forks source link

make vsp library public #2033

Open oshorefueled opened 3 years ago

oshorefueled commented 3 years ago

Currently the vsp library is in the internal directory making it impossible to use the code outside dcrwallet. Making it public would eliminate the need to replicate it in dclibwallet used by dcrandroid, dcrios and godcr.

xaur commented 1 year ago

I guess this will be addressed by #2237

xaur commented 1 year ago

I believe the plan has changed. https://github.com/decred/vspd/pull/382 introduced a circular dependency that was problematic. As a result https://github.com/decred/vspd/pull/395 and #2237 got canceled, and VSP code that made it into the vspd reporisoty was removed in https://github.com/decred/vspd/pull/403 . I think the new plan is to keep the VSP client in dcrwallet repo and make it an exported/reusable package.

JoeGruffins commented 4 months ago

closed by #2359