decred / dcrwallet

A secure Decred wallet daemon written in Go (golang).
https://decred.org
ISC License
216 stars 155 forks source link

spv: fix unsafe waitgroup usage #2335

Closed jrick closed 7 months ago

jrick commented 7 months ago

The goroutine started after receiving an inv also spawns its own goroutines and increments the waitgroup counter. This is invalid waitgroup usage as it could occur concurrently with or after the call to Wait(). Removing the superfluous outer goroutine fixes this issue.

jrick commented 7 months ago

This was merged, but github had an oopsie.