search

decred / dcrwallet

A secure Decred wallet daemon written in Go (golang).
https://decred.org
ISC License
211 stars 153 forks source link

Prompt for account xpub imports at wallet creation #2342

Closed jrick closed 3 months ago

jrick commented 3 months ago

This simplifies the provisioning process as these xpubs will now be included in the address discovery and initial rescan, without manually requiring a RPC call to add them and rescan again for them.

jrick commented 3 months ago

in https://github.com/decred/dcrwallet/pull/2192 we made an assumption that the seed words are always the last thing prompted for, and that's no longer the case now on this pr. It would definitely break existing simnet scripts. We should probably detect EOF for this added prompt at the end (and any other optional prompts we add after this) and still create the wallet with these options unset.

jrick commented 3 months ago

I've tested the latest changes and they fix/keep compatibility with dcr_tmux_simnet_setup.sh.