decred / dcrweb

Decred website code.
37 stars 76 forks source link

Spanish and PT languages showing english on main page #1156

Closed exitus1 closed 5 months ago

exitus1 commented 11 months ago

image

jholdstock commented 11 months ago

There is no technical bug here - the English version of a string is displayed when the translated version is missing. This is intended behaviour because the alternatives are to display nothing in that space, or to completely remove that translation from the site.

Its quite subjective to decide when to keep/remove a language based on how much of it is available. Perhaps we need some kind of policy in place - e.g. remove a language if >20% of the strings are unavailable.

xaur commented 10 months ago

If a translated string is missing showing English string is a good graceful degradation to me.

If a translated string exists but becomes inaccurate over time this is more dangerous. Worst case is it may lead the reader to a wrong decision. From an English side we can avoid this by watching for "breaking changes" in the meaning of English strings, or introduce new IDs instead of changing the meaning of existing IDs.

As for removals, we could benefit from a mechanism to disable a translation without removing it from the repo. Like a simple text file with a list of enabled translations (positive lists and booleans are more robust imo). It will make it easier for translators to update and "resurrect" the translation on the site without digging through Git history.

jholdstock commented 10 months ago

That mechanism already exists in config.yml

xaur commented 10 months ago

Super cool thank you!

I posted this issue in #translators to see if anyone can patch the strings.

exitus1 commented 5 months ago

Old main page, now irrelevant.