decred / decred-release

Decred binary releases.
ISC License
86 stars 42 forks source link

prep for dex 0.5: always install dex, never download/install bitcoin #228

Closed chappjc closed 2 years ago

chappjc commented 2 years ago

Resolves https://github.com/decred/decred-release/issues/227

Our DEX apps will always be installed. Presumably this was not already the default because of the pesky Bitcoin Core requirement at launch. It has been quite some time that that has not been needed. Therefore, this deprecates the --dcrdex switch, always installs the dex apps, and never downloads any third party stuff like bitcoind.

This also includes updates to various things like ioutil, removing silly deps, fixing silly go.mod things, updating copyright years, build tags and comments for Go 1.18, etc.

chappjc commented 2 years ago

The exact opposite way to approach this is to entirely remove dex from dcrinstall.

chappjc commented 2 years ago

Only draft because I've not had time to test anything, but feel free to review.

chappjc commented 2 years ago

Not sure what manifests to update or if https://github.com/decred/release/pull/62 needs to be first.

chappjc commented 2 years ago

Tested with via https://github.com/decred/release/pull/62 and dcrinstall.sh with:

replace github.com/decred/decred-release => github.com/chappjc/decred-release v1.6.0-rc3.0.20220825211652-38a96c47af6d

chappjc commented 2 years ago

Only tested on linux, and canceled install before creating a LN wallet (but after downloading and extracting dcrd, dcrwallet, and dex stuff).