search

decred / decrediton

Cross-platform GUI for Decred.
https://docs.decred.org/wallets/decrediton/decrediton-setup/
ISC License
195 stars 121 forks source link

VSP fee not autoupdating #2024

Open degeri opened 5 years ago

degeri commented 5 years ago

If a VSP changes it fees from lets say 10% to 12%. Decrediton is supposed to auto update the fee, this is not happening and and the ticket is bought with that old fee of 10%.The VSP will now ignore that ticket.

image

Note: This value get refreshed when we click on the "stakepool-manage-pool-button-area" button.

image

image

Tested on [1.4.0] not sure if others are affected.

matheusd commented 5 years ago

How exactly did you test this?

We dispatch a getpurchaseinfo call to each configured VSP at wallet startup time, which should be getting the updated pool fee.

You will get the wrong fee on very long lived wallets that (e.g.) have auto ticket buying on. Though I'm not sure this will be a very frequent problem - I don't think pools are changing their fees so often that this will be a major problem.

They should be communicating the change to their users as well, since specially a fee increase is a change in usage terms.

degeri commented 5 years ago

Testing method as follows.

  1. Setup local VSP
  2. Add local VSP to Decrediton.
  3. Increase the fee at the VSP end.
  4. Buy a ticket and observe it is buying with old fee.
  5. Restart Decrediton and observe that the value is still not updated.

  6. Finally clicking on the "stakepool-manage-pool-button-area" button updates the values.(This to only after a restart)

Agree that VSP should be communicating the changes to users.

Also should we have an alert and confirm with the user if fee changes ?)