decred / decrediton

Cross-platform GUI for Decred.
https://docs.decred.org/wallets/decrediton/decrediton-setup/
ISC License
195 stars 121 forks source link

[windows] Error with releases after 1.6.2 #3674

Open alexlyp opened 2 years ago

alexlyp commented 2 years ago

decrediton_error_smaller

All releases after 1.6.2 (1.6.3, 1.7.0-rc1, 1.7.0-rc2) User reported this happened on their Windows10 machine with an amd processor (and no anti-virus).

But same user reported that the same decrediton files worked on a different Windows10 machine with an intel processor (with anti-virus).

alexlyp commented 2 years ago

As @jrick pointed out, it's possible something related to this being "run as administrator"

alexlyp commented 2 years ago

Another report of the same issue with a fresh install of Windows 10 with Intel processor. The same user reported that it worked as expected on the same machine (with dual boot) that had windows 11 (that also had CLI installed).

alexlyp commented 2 years ago

https://github.com/webpack-contrib/node-loader/issues/46 Maybe related? Something about absolute pathing possibly? But wouldn't explain why it works on some and not others.

alexlyp commented 2 years ago

IMG_20220127_031403

gravityz3r0 commented 2 years ago

Untitled

A clearer of the pic above.

Dual OS Decrediton 1.7.0 W10 (also contain CLI suite) - Not working W11 (no CLI installed here) - Works fine

Both OS are freshly installed and Decrediton is also installed for the very first time.

Intel i5 11400F

hypernoob commented 2 years ago

Tested on my VM. Installing VC++ 14 Redist fixed the error.

alexlyp commented 2 years ago

@hypernoob ah very interesting! Thanks.

@gravityz3r0 can you give that a try on your w10 machine that's not working? I believe you should be able to find the VC++ 14 Redist in the Microsoft Store.

gravityz3r0 commented 2 years ago

@alexlyp i can confirm that the solution above worked. However, VC++ isnt available readily in Microsoft Store, one will have to find it manually from the microsoft website, or the faster way would be to google it. I got it from

https://docs.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170

Not sure why some system are affected and some not, maybe you can try repackage Decrediton such that VC is checked and automatically installed to fix these edge cases.

alexlyp commented 2 years ago

Ah sweet, thanks for following up on this. Hrm yah that's a reasonable thing to look into. I'll see if the electron-builder we use have anything for that.

alexlyp commented 2 years ago

https://github.com/electron-userland/electron-builder/issues/4679

Believe that would fix this issue permanently, I'll look into writing up a proper nsi script that can include this VC++ redist dep.

jzbz commented 1 year ago

Just adding another confirmation that on a fresh Windows 11 install the error gets thrown as well.

An alternative way to resolve the dependency using winget via CLI:

winget install Microsoft.VCRedist.2015+.x64

I agree that it should probably be bundled With Decrediton if possible, as the only users who won't be affected by this are ones who have unknowingly pulled the dependency in when installing something else.

Otherwise we should have some kind of warning on the download page leading to documentation explaining the issue.