search

decred / decrediton

Cross-platform GUI for Decred.
https://docs.decred.org/wallets/decrediton/decrediton-setup/
ISC License
195 stars 120 forks source link

grpc node_module causing build errs in webpack (or watchify) #8

Closed alexlyp closed 7 years ago

alexlyp commented 7 years ago

When attempting to: import grpc from 'grpc' in any file in app/ webpack is not able to properly build it and gives crazy parsing errors.

This may have something to do with webpack config setup or package.json settings.

alexlyp commented 7 years ago

So we've successfully been able to import grpc with the current README.md instructions.

I'll leave this issue open until we've confirmed that we can properly package/build/release the app

jcvernaleo commented 7 years ago

@alexlyp npm run package works fine for me on linux and macOS. I can even run the packages it builds (don't know if they work, but that would be another issue).

So is this issue still valid or can we close it?

alexlyp commented 7 years ago

Yah closing now