decred / gominer

Go (golang) based GPU miner for Decred.
GNU General Public License v3.0
162 stars 80 forks source link

some shares go unaccounted #101

Closed jolan closed 8 years ago

jolan commented 8 years ago

[INF] MINR: Global stats: Accepted: 8504, Rejected: 23, Stale: 163 [INF] MINR: Global utility (accepted shares/min): 1.4644604853407575 [INF] MINR: DEV #1 (Hawaii) reporting average hash rate 1.722GH/s, 8735/8735 valid work

8735 - 8504 - 23 - 163 = 45 or .52%

I haven't caught this with trace on but I did notice:

[INF] POOL: Unhandled message: {"id":8732,"result":true,"error":null}

I think this only happens when you find and submit shares in short order. Probably something like:

Share 1 is submitted Share 2 is submitted Share 1 reply received (unhandled and unaccounted) Share 2 reply received

So I think we just need to save the previous submit as well as the current submit.

jcvernaleo commented 8 years ago

I've seen that unhandled message message as well. Seems like a pretty reasonable theory for inaccurate count.