search

decred / gominer

Go (golang) based GPU miner for Decred.
GNU General Public License v3.0
160 stars 80 forks source link

Remove unneeded word in INFO log line #114

Closed jcvernaleo closed 7 years ago

jcvernaleo commented 7 years ago

Closes #113

jcvernaleo commented 7 years ago

Any further suggestions for simplifying that output would be appriciated of course.

jolan commented 7 years ago

I don't think this goes far enough. I'd rather really improve it to be much shorter so it fits within 80 chars unless you have a long device name.

I think the units make it pretty clear what each field is so I'd rather shorten it to something like:

minrLog.Infof("DEV #%d (%s) %v F=%v%% T=%vC")

Since that would remove the valid work field, we'd have to improve the miner.go stats:

jcvernaleo commented 7 years ago

Intel(R) HD Graphics Haswell GT2 Desktop I do have a long device name :)

jolan commented 7 years ago

Yeah I know, I would like to fix that eventually too by strings.Replace()'ing some of that crap in getDeviceInfo().

jcvernaleo commented 7 years ago

Oh and I agree that since the global stats prints it the valid work part is actually kind of redundant to have every time. I'll update the PR.

marcopeereboom commented 7 years ago

I like verbosity on this tbh. Why is this an issue?

jcvernaleo commented 7 years ago

It is an issue because I need to have a very large terminal to be able to read the output.

jolan commented 7 years ago

Looks a ton better, thanks.

tACK & OK