README: Windows environment variables in DOS are delimited by %

decred / gominer

Go (golang) based GPU miner for Decred.

GNU General Public License v3.0

160 stars 80 forks source link

README: Windows environment variables in DOS are delimited by % #134

Closed gratefulcheddar closed 7 years ago

gratefulcheddar commented 7 years ago

$GOPATH should read %GOPATH% if user is using Windows Command Prompt

jcvernaleo commented 7 years ago

I'm not sure we actually support building from the Windows Command Prompt. Building requires a whole bunch of things installed from msys2 so I think that environment might be the only way the current instructions work. I don't really do windows so I can't say for totally sure though. @jolan could you comment (and close the issue if I'm correct and we only support msys2 building)?

jolan commented 7 years ago

It's how it is mostly for consistency. Some steps need to be done through git-bash and others can be done with or without git-bash.

gratefulcheddar commented 7 years ago

Whether or not I was supposed to use Command Prompt, I was still successfully able to build using the README instructions (slightly annoying because cmd had to be restarted after every step).

jcvernaleo commented 7 years ago

If some steps require git-bash I'd prefer a single path through (so only describe that build method) but since I don't use Windows my vote isn't worth much there and I'm cool with whatever the two of you agree on.