decred / gominer

Go (golang) based GPU miner for Decred.
GNU General Public License v3.0
159 stars 77 forks source link

Updates gominer README with build instructions for mac, updated link … #185

Closed s-ben closed 10 months ago

s-ben commented 5 years ago

This is the result of my journey building gominer from source for mac, getting it working, and seeing some doc improvements that will (hopefully) be helpful.

Makes the below updates/tweaks.

jcvernaleo commented 5 years ago

@dajohi My reviews don't count any more but I think this looks good and you should merge it in.

dajohi commented 5 years ago

@s-ben please update README to handle go 1.11. (remove dep, for instance)

s-ben commented 5 years ago

@dajohi , it looks like you updated the README for Linux yesterday; don't see any remaining references to dep. So I just added a general paragraph (below) about modules being added. Got this text from the Politeia README and lightly edited it. I googled a bit looking for equivalent instructions on windows, but didn't find anything...presumably Windows users can figure that out with a heads up at the top of the build instructions.

NOTE: Go 1.11 introduced modules, a new dependency management approach, that obviates the need for third party tooling such as dep.

Usage is simple and nothing is required except Go 1.11. If building in a folder under GOPATH, it is necessary to explicitly build with modules enabled. For Linux installations, this is implemented in the build commands below. For more information on this requirement, see the How to Use Modules page on the Go wiki.

P.S. My rebase with the latest changes got a bit messy. Might want to double check that I didn't screw up any recent changes.