search

decred / gominer

Go (golang) based GPU miner for Decred.
GNU General Public License v3.0
162 stars 80 forks source link

use nvml to fetch fan and temperature information #96

Closed jolan closed 8 years ago

jolan commented 8 years ago

Initial NVML support. It could go into the OpenCL path too but I don't think that makes sense. Plus I'd rather not make building messier than it already is until #83 happens.

Might want to add an nvml.Shutdown() after all the devices are released down the road but it doesn't seem to matter in practice.

Doesn't seem to affect performance either.

Closes #63.

jcvernaleo commented 8 years ago

Is there a reason you added the nvml-go files rather than importing it (and adding to glide) from whereever the upstream is.

Other than that it seems to work with no issues or performance regressions for me.

jolan commented 8 years ago

I did it primarily since it makes it easier to adjust the default CGO_CFLAGS/CGO_LDFLAGS to something sensible which will be useful whenever Windows is building properly.

jcvernaleo commented 8 years ago

Makes sense. Could you add the url for the upstream repo to the commit message in case we want to update it or switch to upstream at some point?

jolan commented 8 years ago

Done.

jcvernaleo commented 8 years ago

OK (once travis is done).