search

decred / insight

A Decred blockchain API for web wallets.
10 stars 22 forks source link

Pruned tx is requested with /address/Ds... all tx fail to load #10

Open alexlyp opened 8 years ago

alexlyp commented 8 years ago

When a tx is not found via RPC request during Address.update it errors out incorrectly.

Appears that getTransaction in app/controllers/transactions.js has incorrect callback return.

Should return err and null txinfo, then above it should catch the err and carry on loading tx

YSTomar commented 7 years ago

@alexlyp, I hope you are talking the about the insight-api codebase for "Appears that getTransaction in app/controllers/transactions.js has incorrect callback return."

currently error message is "Appears that getTransaction in app/controllers/transactions.js has incorrect callback return.", It refers to https://github.com/decred/insight-api/blob/23d38a0bfcc3cafebe9318d288891512fff33eb1/app/controllers/transactions.js#L96

Please let me know for this ticket can I work on insight-api, or needed to create separate ticket on insight-api.

alexlyp commented 7 years ago

Yes, please do any work on insight-api that you deem necessary.

YSTomar commented 7 years ago

Please review the PR