decred / tinydecred

Python tools for Decred
ISC License
27 stars 14 forks source link

tinywallet: some more cleanup #168

Closed teknico closed 4 years ago

teknico commented 4 years ago

This completes the cleanup of docstrings, comments and code in the tinywallet package. Based on #167.

teknico commented 4 years ago

Am unable to run tinywallet:

[joe@hyrule tinywallet]$ poetry run python tinywallet/app.py --testnet --loglevel=debug

Not sure why that worked before and doesn't anymore, but the correct command to run tinywallet in the development environment is:

$ poetry run tinywallet

Poetry creates a ./.venv/bin/tinywallet script that sets up the Python environment before running the program.

JoeGruffins commented 4 years ago

That way of starting worked in a932cab but no longer in 94ca282. Your way works though, after starting up hit with this:

[joe@hyrule tinywallet]$ poetry run tinywallet --testnet --log=debug
2020-04-21 09:15:23,927 app INFO initLogging(170) configuration file at /home/jo
2020-04-21 09:15:23,927 app INFO initLogging(171) data directory at /home/joe/.l
<class 'ValueError'> Invalid format specifier <traceback object at 0x7f16b81baec0>
Traceback (most recent call last):
  File "/home/joe/git/tinydecred/tinywallet/tinywallet/qutilities.py", line 118, in callitback
    self.callback(self.returns)
  File "/home/joe/git/tinydecred/tinywallet/tinywallet/screens.py", line 2809, in setPools
    self.randomizePool()
  File "/home/joe/git/tinydecred/tinywallet/tinywallet/screens.py", line 2830, in randomizePool
    self.score.setText(f"{self.scorePool(pool):.1f%%}")
ValueError: Invalid format specifier
teknico commented 4 years ago

after starting up hit with this:

Ouch, sorry. I really miss having tests.