search

decred / tinydecred

Python tools for Decred
ISC License
27 stars 14 forks source link

multi: add accounts screen #94

Closed buck54321 closed 4 years ago

buck54321 commented 4 years ago

Step 1 of a few to implement full account functionality through the UI. Refactors a lot of UI code and simplifies the Wallet API. Also adds a SimpleWallet type, which is a single-account Decred wallet.

Adds an account selection screen. Right now, there is still only one account available, and no option to create more. That will follow in the next step.

buck54321 commented 4 years ago

I switched to pathlib.Path for the code in decred, but not yet in tinywallet. Qt expects strings, and Path doesn't serialize for the configuration file. Punting for now.

As far as PR size, you point is well taken, but it's not always going to work out quite so clean and neat, especially as we hack out basic features. I only mention it because there are likely some large and far-reaching PRs coming up that are certain to be over 500 loc diff. If you're not comfortable putting your stamp on something because it's too big, which is totally understandable, just give me a heads up.