search

decrypto-org / blockchain-course

An interactive course on blockchain science and engineering
MIT License
14 stars 11 forks source link

Default assignments folder in .env is incorrect #32

Closed dionyziz closed 5 years ago

dionyziz commented 5 years ago

It is ./assignments, but this refers to api/db/assignments, while the correct folder is db/assignments (outside the api dir).

cnasikas commented 5 years ago

Inside db/models/custom/assignment.js in line 1 the assignments' folder is declared as

const ASSIGNMENT_FOLDER = process.env.ASSIGNMENT_FOLDER || '../../assignments'

The correct should be ../../assignments but it seems redundant to declare it again. I think is better to leave it empty. What do you thing ?

dionyziz commented 5 years ago

Either way is fine, as long as the default environment works out of the box.