Closed cnasikas closed 5 years ago
OrfeasLitos
commented
5 years ago In my opinion, if a player has already solved the exercise in the past and they try again with a wrong solution, the status shouldn't be changed.
If they try for the first time and fail, then the status could or could not change. Let's just ensure that, if we decide to have it change, the player doesn't think that they cannot try again.
cnasikas
commented
5 years ago Ok! I agree that it will be confusing, you are right. My main concern is how we will handle a submitted solution ? What if in the future we introduced a tiered grading system that have a minimum pass (solved) grade but then the user can improve her score ?
A solution to this will be to not save the user's solution if it is a failed one and save otherwise. What do you think ?
dionyziz
commented
5 years ago Just keep the best solution so far.
On Fri, Feb 22, 2019 at 6:32 AM Christos Nasikas notifications@github.com wrote:
Ok! My main concern is how we will handle a submitted solution ? What if in the future we introduced a tiered grading system that have a minimum pass (solved) grade but then the user can improve her score ?
A solution to this will be to not save the user's solution if it is a failed one and save otherwise. What do you think ?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/decrypto-org/blockchain-course/issues/36#issuecomment-466351685, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhPPCJbszJ9iPCB4lH9Qf59XrPpABriks5vP8dKgaJpZM4bJS6G .
cnasikas
commented
5 years ago How you define the best solution ? For the moment the grader is a pass or fail system.
The default db value of solved column is false. When a user submits a correct solution the solved status variable changes to true. If the user submits another wrong solution the status is not changed but the new solution (wrong in this example) is saved.