search

decrypto-org / blockchain-course

An interactive course on blockchain science and engineering
MIT License
14 stars 11 forks source link

Async solutions #44

Closed cnasikas closed 5 years ago

cnasikas commented 5 years ago

@gtklocker @dionyziz It is ok to merge ?

dionyziz commented 5 years ago

That's one reason we need unit tests to make such refactorings trivial ;) OK let's do it later.

On Tue, Apr 30, 2019 at 2:01 PM Christos Nasikas notifications@github.com wrote:

@cnasikas commented on this pull request.

In db/judge/SolidityJudge.js https://github.com/decrypto-org/blockchain-course/pull/44#discussion_r279705890 :

@@ -140,6 +163,20 @@ class SolidityJudge extends BaseJudge { hash (...args) { return this.web3.utils.soliditySha3(...args) } +

  • promisifyTransaction (tx, args) {

I know man :). Even that is a pain. I have to test it again for each assignment. So ensureConfirmed or awaitTx ? I don't care. This await tx.ensureConfirmed() let's leave it (if it is easy and possible) to another PR

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/decrypto-org/blockchain-course/pull/44#discussion_r279705890, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEE6PHNEGHDPU6J3COS33DPTARKHANCNFSM4HH6KWTQ .