ded / bonzo

library agnostic, extensible DOM utility
Other
1.32k stars 137 forks source link

Add a version tag for bower #111

Closed bogdan-kulynych closed 11 years ago

bogdan-kulynych commented 11 years ago

Currently bower checks out bonzo version '1.0.0' (built 2 years ago), which won't include setQueryEngine, for example. Though the current version seems to be '1.3.0', bower will only recognize it if there is a Git tag.

rvagg commented 11 years ago

done, current version is 1.3.2-1, can you let us know if the -1 causes an problems for Bower?

bogdan-kulynych commented 11 years ago

Yes, it causes problems

$ bower install bonzo 

bower cloning git://github.com/ded/bonzo.git
bower cached git://github.com/ded/bonzo.git
bower fetching bonzo
bower checking out bonzo#1.3.2-1
mismatch The version specified in the component.json of package bonzo mismatches the tag (1.3.2-1 vs 1.3.0)
mismatch You should report this problem to the package author
bower copying /home/bogdan/.bower/cache/bonzo/2ddc38961b065dac7592ab92f5d74dc7
bower installing bonzo#1.3.2-1

There was no problems with yeoman though

$ yeoman install bonzo

Running "bower:install:bonzo" (bower) task
GET https://bower.herokuapp.com/packages/bonzo
bower cloning git://github.com/ded/bonzo.git
bower cached git://github.com/ded/bonzo.git
bower fetching bonzo
bower checking out bonzo#1.3.2-1
bower copying /home/bogdan/.bower/bonzo/2ddc38961b065dac7592ab92f5d74dc7
bower installing bonzo#1.3.0

Done, without errors.
ded commented 11 years ago

ugh. so dumb. i'll make a script that republishes both instead of doing them each manually.

ded commented 11 years ago

also, i just added a v1.3.3 git tag