search

ded / bonzo

library agnostic, extensible DOM utility
Other
1.32k stars 137 forks source link

Fixed offset function for objects in iframes. #114

Open velocityzen opened 11 years ago

velocityzen commented 11 years ago

So. It passed tests of course.

getWindowScroll() function had some bugs.

  1. pageXOffset and pageYOffset properties not supported by IE 8 and earlier
  2. When you trying to get offset for node in iframe, getWindowScroll must return scroll inside iframe. Not for global window.
rvagg commented 11 years ago

hey @velocityzen, any chance you could think up some additional tests for these to demonstrate the original problem(s) so we don't get regressions in future?

velocityzen commented 11 years ago

Yeah.

rvagg commented 11 years ago

how are we going on those tests @velocityzen, any brilliant ideas to be able to capture this as a test case?

velocityzen commented 11 years ago

Hello. Don't have a time for this, sorry. Test case is simple. Just check element positioning inside iframe!

rvagg commented 11 years ago

will leave this open for now in case anyone else has time to add tests for this, otherwise it'll probably just be closed at some point in the future.