search

ded / bonzo

library agnostic, extensible DOM utility
Other
1.32k stars 137 forks source link

Fixed CSS Opacity in Internet Explorer #122

Closed jacobbuck closed 10 years ago

jacobbuck commented 11 years ago

This should fix #121.

rvagg commented 11 years ago

looking good, could you also have a go at adding some basic tests for this? it's tricky to test the actual opacity but could you add at least a test for setting opacity to 0 and then getting the value and making sure it's 0, same for 1.

jacobbuck commented 11 years ago

Just read the Contributing part of the readme and realised I was doing it wrong :sweat_smile:. Updated the correct files and added tests.

rvagg commented 11 years ago

Fantastic @jacobbuck, I'll try and get this verified on my end and a release out asap. Ping me here if you don't see any action within a couple of days!

jacobbuck commented 11 years ago

Hey @rvagg, just checking up on this pull request.

rvagg commented 11 years ago

fyi I'm not totally ignoring this, thanks for reminding me, I just need to get to my computer that has my raft of virtual machines on it for testing and then I'll get it out! stay tuned.

rvagg commented 10 years ago

:thumbsup: very sorry for the delay, finally back at my desktop where I have my stable of VMs.

released as @1.3.6

ded commented 10 years ago

thanks @rvagg