ded / bonzo

library agnostic, extensible DOM utility
Other
1.32k stars 137 forks source link

use `win.` in `.viewport` #123

Closed emirotin closed 11 years ago

emirotin commented 11 years ago

We had an issue on some 3rd party site due to self being globally rewritten by other script While that's obviously not Bonzo's fail it's quite possible to accure due to non-experienced programmers copying self = this pattern and forgetting var.

I think the change is also healthy due to making the code more consistent — that was actually the only place referencing to self.

rvagg commented 11 years ago

I'm cool with this, @ded?

ded commented 11 years ago

hmm... wonder why this isn't merging..

ded commented 11 years ago

merged