search

ded / bonzo

library agnostic, extensible DOM utility
Other
1.32k stars 137 forks source link

Fixed issue #6 #7

Closed dawnerd closed 13 years ago

dawnerd commented 13 years ago

Updated .show() to accept a display property. If no property is set, block is used.

ded commented 13 years ago

the merits of this are good. please use the submodule reference to the sink tests. do:

$ git submodule update --init

also, consider changing the code to:

style. display = type || "";
dawnerd commented 13 years ago

Is there any reason why elements is passed into both .show and .hide? It doesn't look like it's being used. I'm making the changes you suggested right now.

ded commented 13 years ago

reason is that it was accidentally left from old. it can be removed now.

ded commented 13 years ago

also, thanks for being patient as I check thru emails, twitters, and github.... my wife has been in labor the last few hours :/

dawnerd commented 13 years ago

Oh wow! I'll have an updated patch ready sometime tonight.